Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exodus to 19.10.18 #40

Closed
wants to merge 4 commits into from
Closed

Update exodus to 19.10.18 #40

wants to merge 4 commits into from

Conversation

dvreed
Copy link
Contributor

@dvreed dvreed commented Oct 23, 2019

Current version in flathub is two versions old. Update to latest 19.10.18 released on Oct 18

@flathubbot
Copy link
Contributor

Started test build 10444

@dvreed
Copy link
Contributor Author

dvreed commented Oct 23, 2019

I am unable to test my change locally as I get a SUID error when trying to run the resulting build. Is there something special you do to the flathub builds that gets around this electron error?

@flathubbot
Copy link
Contributor

Build 10444 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/9944/io.exodus.Exodus.flatpakref

@TingPing
Copy link
Member

You have to disable the sandbox, passing --no-sandbox to the launcher may work.

@dvreed
Copy link
Contributor Author

dvreed commented Oct 23, 2019

It seems that it doesn't like it... forgive me I'm a flathub newb

$  flatpak install --user https://dl.flathub.org/build-repo/9944/io.exodus.Exodus.flatpakref
$  flatpak run io.exodus.Exodus --no-sandbox
Gtk-Message: 13:43:15.759: Failed to load module "canberra-gtk-module"
Gtk-Message: 13:43:15.759: Failed to load module "pk-gtk-module"
Gtk-Message: 13:43:15.759: Failed to load module "canberra-gtk-module"
Gtk-Message: 13:43:15.759: Failed to load module "pk-gtk-module"
ENV: production
Can only pass whitelisted args; exiting

Whereas the one currently in flathub doesn't need extra arguments

$  flatpak run io.exodus.Exodus
Gtk-Message: 13:44:44.642: Failed to load module "canberra-gtk-module"
Gtk-Message: 13:44:44.642: Failed to load module "pk-gtk-module"
Gtk-Message: 13:44:44.642: Failed to load module "canberra-gtk-module"
Gtk-Message: 13:44:44.642: Failed to load module "pk-gtk-module"
ENV: production
(node:2) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Exodus (production): DATA DIR: /home/dareed/.var/app/io.exodus.Exodus/config/Exodus
main: 1060.076ms
Using wasm:  true

SET WALLET LOADED action: null loadedFrom: passphrase
true

@TingPing
Copy link
Member

TingPing commented Oct 23, 2019 •
edited
Loading

You'll have to dig into how the electron launcher works. Being proprietary its possible this is a very annoying problem to solve if they whitelist the args in their app.

@AHappyUser
Copy link
Collaborator

In release 19.10.11 Exodus added a new file called "chrome-sandbox".
When running the test build I get an error with that file name.

[admin@fedora Test]$ flatpak run io.exodus.Exodus [2:1024/153718.015839:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /app/extra/chrome-sandbox is owned by root and has mode 4755.

I hope this is helpful!

@t-nelis t-nelis mentioned this pull request Nov 20, 2019
Closed
dvreed added 2 commits April 7, 2020 14:24
@dvreed
Add zypak source
155aa49 
(cherry picked from commit abdfdaa3b2a68437e46e7a6d413f5f81494692ac)
@dvreed
Use zypak-wrapper to workaround sandbox error
82dc382 
(cherry picked from commit 71b8166)
@flathubbot
Copy link
Contributor

Started test build 18068

@flathubbot
Copy link
Contributor

Build 18068 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17324/io.exodus.Exodus.flatpakref

@dvreed dvreed mentioned this pull request Apr 7, 2020
Merged
@TingPing
Copy link
Member

TingPing commented Apr 7, 2020

Closing in favor of #41

@TingPing TingPing closed this Apr 7, 2020
@dvreed dvreed deleted the update_19.10.18 branch April 7, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dvreed @flathubbot @TingPing @AHappyUser @dareed